Dimitar Krastev
Dimitar Krastev
> This issue was fixed in #1500 It hasn't been fixed. That was only Task 1. The underlying IP is still stored in `pcap_addr_t` which I can't remove until `PcapLiveDevice::getAddresses()`...
Still present, as the remote device class does not have its own `clone` override. I was mostly waiting for the clang format PRs to be done with before I start...
Sure. Btw @seladb , is there a specific reason we are cloning the devices via re-fetching the `pcap_if_t` struct? As far as I can see, the struct is only read...
Fixed by #1497
Sure, contributions are always welcome. Follow the [Contributing guidelines](https://github.com/seladb/PcapPlusPlus/blob/master/CONTRIBUTING.md) when opening your PR. As for the second question, the answer is unfortunately no, as the library is keeping to C++11...
As per the [contributing guidelines](https://github.com/seladb/PcapPlusPlus/blob/master/CONTRIBUTING.md), please retarget the PR to the `dev` branch instead of the `master`.
> @seladb I need support for CI pipelines, I can't figure out why are they still failing. And a clear documentation was successfully added to PR body to make it...
> @Dimi1010 , could you please support, what could be the reason of failed pipeline here ? from the doxygen pipeline ``` /__w/PcapPlusPlus/PcapPlusPlus/Packet++/header/DoIpLayerData.h:1091: warning: Compound pcpp::DiagnosticPowerModeRequestData is not documented. /__w/PcapPlusPlus/PcapPlusPlus/Packet++/header/DoIpLayerData.h:1066:...
> - It doesn't prevent code duplication because each `checkMtu()` override is only used once (unless I'm missing something) The initial idea was to separate the logic for checking a...