Sarah Groß

Results 252 comments of Sarah Groß
trafficstars

This shall be fixed once we implement [opentypejs/opentype.js/#648](https://github.com/opentypejs/opentype.js/pull/648)

> After I fixed it, I got a infinite loop between [RawDataParser->decodeXref()](https://github.com/smalot/pdfparser/blob/b32bb7a35e24f39c4bd5cfff124b590767dea2e0/src/Smalot/PdfParser/RawData/RawDataParser.php#L212) and [RawDataParser->getXrefData()](https://github.com/smalot/pdfparser/blob/b32bb7a35e24f39c4bd5cfff124b590767dea2e0/src/Smalot/PdfParser/RawData/RawDataParser.php#L834) this seems to be related to one of the memory leak issues outlined in #104

An Exception would halt the parsing process completely (or would have to be caught and handled by other methods), meaning that no content could be parsed from corrupted/invalid files at...

Sounds like a good idea, so +1 from me, but I don't have the time right now to contribute anything to it, unfortunately.

I just fixed the linting issues and rebased on the current master. How did you spot this issue before you opened #546? Didn't you havve a font with which you...

This will break the writing of the value in https://github.com/opentypejs/opentype.js/blob/master/src/table.js#L170 - could you implement that as well? edit: also, the format used for feature parameters is different for each feature...

I just noticed this seems to be a duplicate of #452

Does this make #491 redundant, or do we have to consolidate the two? Could you please have a look at each other's code @rafallyczkowskiadylic & @AlexandreRivet?