opentype.js icon indicating copy to clipboard operation
opentype.js copied to clipboard

Published 20 hours ago • verified publisher icon opentypejs

Update hmtx.js to read leftSideBearing array when numGlyphs > numMetrics

Open sigurdle opened this issue 2 years ago • 7 comments
trafficstars

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I did npm run test and all tests passed green (including code styling checks).
  • [ ] I have added tests to cover my changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the README accordingly.
  • [ ] I have read the CONTRIBUTING document.

sigurdle avatar Feb 07 '23 20:02 sigurdle

@sigurdle does this break any tests. Also can you write a test for this?

ILOVEPIE avatar Feb 07 '23 21:02 ILOVEPIE

@sigurdle any updates on writing tests for this?

ILOVEPIE avatar Feb 11 '23 19:02 ILOVEPIE

Pinging @sigurdle

Connum avatar Feb 22 '23 00:02 Connum

@sigurdle any news?

Connum avatar Mar 02 '23 21:03 Connum

Hi, I apologize, I am not well versed in the the "correct" way to add new code to github repository with tests etc. I also see above that there are some failings happening with eslint in the code I added. Is that just spacing issues? It would be best if someone looks at that . As for testing, that would mean finding a suitable font. I haven't looked at that.

sigurdle avatar Mar 03 '23 10:03 sigurdle

I just fixed the linting issues and rebased on the current master. How did you spot this issue before you opened #546? Didn't you havve a font with which you encountered issues?

Connum avatar Mar 03 '23 11:03 Connum

I spotted it by accident as I was reading the spec

sigurdle avatar Mar 04 '23 19:03 sigurdle