Sarah Groß

Results 252 comments of Sarah Groß
trafficstars

> @Connum quick question, when we merge this, will it affect #542 at all? Just curious. No, these labels are stored with the features and independent from the platform-specific font...

Yeah, let's do the optimizations in a separate PR! Other than that, it looks good to go!

> @Connum did we run the tests? Narf! No we didn't! 😉 I'll look into it!

Ok, so the thing is that the "Preserve platform specific names in fonts" feature has broken this one. Now, all the feature labels for character variants and stylistic types are...

So I just read the spec and feature names can indeed be platform-specific as well, so we can't get rid of the overhead that the platform preservation has caused: https://learn.microsoft.com/en-us/typography/opentype/spec/name#naming-table-header...

> that sounds good but I don't think those numeric indexes are supposed to be showing up in the names object. Where should we store them instead?

Numeric names indexes are by the way already sotored that way, so I don't think this should be fixed in this PR.

Duplicate of #272 Edit: OK, I misunderstood, but still this is out of scope for a library like ours.

Let's wait for the outstanding feature PRs, one of them introduces the groundwork for correct handling of feature execution order.

It seems like most of the maintainers are currently busy with other projects and work. Also, the users who provided the PRs have often not yet replied to reviews and...