Benoît Cortier

Results 161 comments of Benoît Cortier

Thank you! Please apply the PR guidelines: https://github.com/Devolutions/devolutions-gateway/blob/master/AGENTS.md#pull-request-guidelines issue: We would use the `build` type for this kind of change. note: I need to verify if this is fine for...

In RDM, we have a list of "**preferred** encodings" Also, here is what @thenextman said on this topic: > I would think hard about giving the user a list of...

> > In RDM, we have a list of "**preferred** encodings" > > > > Also, here is what @thenextman said on this topic: > > > I would think...

> In `IronEncodingSet`, we also have pseudo-encoding, and with this change, we need to pay attention to keep sending them for all possible encoding sets. If we refactored `IronEncodingSet` to...

> Another solution can be to have the pseudo-encoding in a separate set (it might be hardcoded, and user code won't be able to change it) Makes sense too! :thinking:

Thank you for improving this! I’m waiting for @pauldumais to confirm the problem is fixed on his side (thread on Slack).

@TheBestTvarynka Is the PR ready? I saw on Slack that the problem was fixed.

Thank you! I'm currently on vacation, I'll review next week!