Fix memory corruption in the `AcquireCredentialsHandleA/W` functions
Hi,
In this PR I've fixed the memory corruption error in the AcquireCredentialsHandleA/W functions. The user can safely pass the null/empty credentials strings.
Also, I covered such cases with tests.
Thank you for improving this! I’m waiting for @pauldumais to confirm the problem is fixed on his side (thread on Slack).
Thank you for improving this! I’m waiting for @pauldumais to confirm the problem is fixed on his side (thread on Slack).
I'm still getting the memory corruption error when I pass a blank string as username. It seams to me that sending a blank string just like sending an invalid username like "a" should return the same failed authentication, instead of a memory exception. I agree that null should not be supported in sspi-rs.
@TheBestTvarynka Is the PR ready? I saw on Slack that the problem was fixed.
Is the PR ready?
Yes, we can merge it once CI is happy.