Benoît Cortier
Benoît Cortier
Hi! Maybe our input event handling logic is lacking. Since you are building from master, I think you could easily provide us with more troubleshooting information. At this place: https://github.com/Devolutions/IronRDP/blob/af7deae70ab21435e9f0a864210b17c63efdd9e3/crates/ironrdp-client/src/app.rs#L159-L172...
> What is the status on this? > > At the moment I am using the `file_rotate` instead of any `tracing` implementation. Is there still motivation to change this, so...
@pacmancoder Can you look into this when you have some time? Not urgent.
I’m impressed by the characteristics of this codec, especially given how _simple_ the compression format is. As a custom codec, it seems to be a solid alternative to JPEG: -...
> @CBenoit I think we should be good to start reviewing this series. I can split various preliminary patches in different MR if you prefer? Sounds great! Yes, I would...
Hi @elmarco Do you want me to review this now?
Sounds great! I’m starting the review. First, this commit is not following the convention: [benches:: fix could not find time in tokio](https://github.com/Devolutions/IronRDP/pull/670/commits/c9362d4c66debf7fa60f7fe5b0f5d0d33c374a27) I guess this should be `chore(bench):` or `chore(benches)`...
I’m done with the review. As always, excellent job!
Hi! Sorry for the delay here. I’ll be busy for a while, but I think I’ll be able to look into it on Friday or next Monday!
Hi! I’ll come up with a detailed roadmap in the next few days and let you know about it. Mainly, I want to adjust a few last things in the...