Andrew Gallant

Results 1903 comments of Andrew Gallant

This looks reasonableish, yes. I'd like to see its API cleaned up a bit. Namely: 1. It looks like it should be named `escape_debug` instead of `escape_unicode`? Namely, [`escape_unicode` in...

Apologies of leading you down the wrong path here, but as noted in #37, I think we should add APIs that mirror std for this as closely as possible. In...

This _seems_ reasonable to me. Although I think this does come with a pretty big caveat that in the context of `bstr`, the value returned by this function is merely...

It's a good idea. One of the possible use cases here is in a regex engine, although using routines like this effectively in that context isn't straight-forward. I'd probably prefer...

Thanks! :-) You didn't miss anything, I have no RSS feed. I usually only update this repo when I add a post, so that's a pretty good work-around. But adding...

I think there would be fine to add, yes. I believe the necessary APIs for implementing this are already available on the ByteOrder trait.

If that's the only implementation choice, then we probably shouldn't provide it.

I think this is _probably_ okay... I'm a little skeptical of adding these, because it's a lot of methods. And it's not clear to be how broadly applicable they are....

I would like to see use cases for this. How many people using `byteorder` have had to invent this abstraction (or something similar) on their own?

@Kixunil Could you elaborate a bit more on your use case? I don't think I understand it.