Andrew Gallant

Results 1938 comments of Andrew Gallant

@lopopolo Sorry, I'm having trouble parsing your comment. The first part seems to be discussing a deficiency with the trim routines while the second part seems to be referring to...

@lopopolo Thanks for responding! There's a lot to unpack here I think... So the first thing that sticks out to me is that the `trim` family functions don't really seem...

No problem! I guess they could also be routines in `ByteSlice`. I'm not quite sure why I made them free functions. Although, since they are free functions and accept `AsRef`...

@thomcc Thanks for diving into this! I don't quite have the bandwidth to dive into this right now. I will at least do it whenever I get back around to...

Just to re-iterate my previous comment: I'm generally okay with giving up a small loss for non-ASCII in favor of making the ASCII case much faster. I'm not going to...

Oooooo yes, this would be lovely. I freaking hate `B`. :-) This will likely motivate to bump the MSRV sooner than I would otherwise. I'll wait until it's at least...

This is a limitation of `Deref`. There is no `DerefMove`. There's nothing I can do about it, sorry. An alternative would be to define inherent methods on `BString`, but I'm...

> Can you not implement the into methods on BString and forward them to the inner `bytes`? If you quoted the rest of that paragraph... > An alternative would be...

Those are all fair points. I suppose if we could do this will minimal fuss using a macro, then I might be on board with it. Adding more explicit constructors...

I think this can probably happen in bstr 1.0. It is mostly a matter of MSRV. But I'm in favor of such things in principle. Although it seems more like...