Andrew Gallant

Results 1903 comments of Andrew Gallant

It is plausible that this is a problem, it's plausible that the compiler might be smart enough to work-around this and it's even plausible that the compiler is not smart...

@itamarst Yeah, in those cases, I tend to revert to ad hoc benchmarks using the `aho-corasick-debug` tool. That is, I run it on much bigger inputs on an otherwise idle...

Yeah I should have updated this. I'm not holding myself up here as a result of the lack of feedback. My plan is to just to go forward with this....

Deprecating them sounds smart though. Might be a good forcing function.

@vks Yeah, there are some cases in which disabling byte classes can make the resulting search faster, but I've only ever seen slight improvements. (I've also seen regressions due to...

In the next semver incompatible release, I am also planning to remove the ability to construct automatons using a smaller state ID representation. Instead, it will be fixed to `u32`...

Aye. I may wind up closing this because I'm not quite convinced this is worth adding because of the implementation complexity. If you need something like this, it might make...

Aye, thanks! The URL is actually going to change once more, so I'll update this when that happens.

This is interesting. I think I'm with you, although looking at it now, I wonder if we could just elide the rewrapping altogether, since I agree that seems weird.

Yeah, I do kind of think this sort of thing is in scope. I've certainly wanted functions like this in the past as well. Adding these sorts of routines for...