Be

> how hard would it be to rip that out? Not sure, but probably not all that hard. No changes would be required in the effects system, only DlgPrefEq.

How about getting rid of the redundant bypass EQ option? It does the same thing as picking None in the combobox.

+208 −314?! This is a major rewrite! How are you going to fix conflicts with a separate rewrite in main??

Without even considering the conflicts with main, I don't think it's a good idea to merge such a big change to the stable branch, particularly for such brittle code, to...

To clarify my previous comments: if someone else thinks it is a good idea to merge this to 2.3 and is motivated to thoroughly review & test the changes, go...

> All the unit tests (except for the last one) pass when run individually, but when I run the whole test suit only the first test passes. On subsequent tests...

Instead of scattering `setMacroRecordable(true)` all over, what COs shouldn't be recordable?

I like the idea to have both macros associated with particular tracks and these generic quick actions. They both open lots of creative possibilities.

I don't understand the use case of this new Control. What does this accomplish that `rateRange` does not do already?

@ronso0 > AFAIK (and what I tried to pin down in the wishlist bug): on the turntable, the rate slider offset is added to rate_ultra fader offset In other words,...