Be

Results 670 comments of Be
trafficstars

> My original hope was to find a one button solution that allows you workflow This does not work as explained years ago at the beginning of https://bugs.launchpad.net/mixxx/+bug/1731779

Ehh... I'm not sure about this. On one hand it does reduce soft-takeover situations. On the other hand it reduces chain presets to just being a list of loaded effects...

The effect loading preference is orthogonal. It determines what happens when loading an effect. The question here is what to do when loading a chain preset. My motivation for implementing...

@julled it will be easier if you [set up pre-commit locally](https://github.com/mixxxdj/mixxx/wiki/using-git#set-up-automatic-code-checking) than rely on GitHub Actions running it for you.

@ywwg Refusing to review code because it's above your arbitrary code size threshold while demanding to drastically expand the scope of PRs is toxic. Likewise, pointing fingers at people for...

Of course, nobody has an obligation to review any particular PR. What I am taking issue with is this behavior of commenting on a PR to explicitly refuse to review...

The new commits look fine to me. I leave it to @Holzhaus to follow up on his prior review.

By the way, thank you for the small, easy to review, self-contained commits with clear commit messages.

So I guess my review doesn't count? Nor does @Holzhaus' review? @ywwg you have a [history](https://github.com/mixxxdj/mixxx/pull/2618#issuecomment-787528962) of belittling others' reviews. It's not okay. Writing "thank you" immediately after pretending like...

I [did review this](https://github.com/mixxxdj/mixxx/pull/4550#issuecomment-986302662) yet @ywwg just posted "Given the lack of anyone else being able to review this". This is disrespectful. > I don't understand what you want. I...