VIP-Coding-Standards

VIP-Coding-Standards copied to clipboard

Improve flush_rewrite_rules warning

1

## What problem would the enhancement address for VIP? Right now here's the rule that we see when you try to use `flush_rewrite_rules()`: > 🚫 Error( severity 5 ): flush_rewrite_rules...

mikeyarce

Add RestrictedCacheGroupSniff to restrict wp-memcached global cache groups

4

Fixes #260

rebeccahum

## What problem would the enhancement address for VIP? Sometimes certain core assets are deregistered/dequeued which break Query Monitor, which adds an extra step during debugging to track that down....

rebeccahum

Fixes #113.

rebeccahum

Convert htmlAttrNotByEscHTML to warning or back to error for consistency with other rules

9

We typically don't have any errors that are below 5 (with 5 being the default severity level). https://github.com/Automattic/VIP-Coding-Standards/blob/60ad148168258afccd05ff0429d53a7e810270a5/WordPress-VIP-Go/ruleset.xml#L259-L261 However, on the VIP Go ruleset, we have `WordPressVIPMinimum.Security.ProperEscapingFunction.htmlAttrNotByEscHTML` marked as an...

rebeccahum

## What problem would the enhancement address for VIP? It would be useful if there was a way for clients to see a more granular report for checking VIP Go...

rebeccahum

Custom IniSet Sniff to allow for certain safelisted options

1

## Describe the solution you'd like VIPCS could benefit from having a custom IniSet sniff...similar to https://github.com/WordPress/WordPress-Coding-Standards/blob/41f5a9c66ff814863bc479fb52fd6cd1abc87e28/WordPress/Sniffs/PHP/IniSetSniff.php#L55-L65, but we want to be able to customize the whitelist property for the...

rebeccahum

## Describe the solution you'd like We should add to the `$HTMLExecutingFunctions` property the following functions: - insertAdjacentHTML - outerHTML ## What code should be reported as a violation? ```...

rebeccahum

## What problem would the enhancement address for VIP? `getimagesize()` holds up the PHP process downloading the entire image to just read its file size. ## Describe the solution you'd...

davidsword

## What problem would the enhancement address for VIP? Because of the container-based infrastructure, VIP does not recommend using the function `filemtime()` to populate a value for versioning; each time...

terriann