VIP-Coding-Standards

VIP-Coding-Standards copied to clipboard

Remove BatcacheWhitelistedParamsSniff

1

Same reason as #612 — no longer needed since WordPress.com sites are migrated.

rebeccahum

Review the WordPressVIPMinimum.Performance.NoPaging sniff

1

Review the `WordPressVIPMinimum.Performance.NoPaging` sniff for the following in as far as relevant to that sniff: - [ ] Code style independent sniffing / Correct handling of quirky code Typical things...

jrfnl

Deprecate WordPressVIPMinimum ruleset

6

With all sites migrated to Go, I think we can deprecate https://github.com/Automattic/VIP-Coding-Standards/blob/develop/WordPressVIPMinimum/ruleset.xml and use https://github.com/Automattic/VIP-Coding-Standards/blob/develop/WordPress-VIP-Go/ruleset.xml as the main source of truth.

rebeccahum

Remove ZoninatorSniff

1

Since all sites have moved from .com, we can remove the sniff since REST API is loaded by default. >  * This sniff reminds the developers to check whether the...

rebeccahum

Replace WordPress.PHP.StrictComparisons with Universal.Operators.StrictComparisons

1

In https://github.com/WordPress/WordPress-Coding-Standards/pull/1919, the `WordPress.PHP.StrictComparisons` sniff was replaced with `Universal.Operators.StrictComparisons`. We currently reference it here: https://github.com/Automattic/VIP-Coding-Standards/blob/60ad148168258afccd05ff0429d53a7e810270a5/WordPress-VIP-Go/ruleset.xml#L216-L218

rebeccahum

## What problem would the enhancement address for VIP? Since WordPress 5.5, we are able to pass argument to a template: https://make.wordpress.org/core/2020/07/17/passing-arguments-to-template-files-in-wordpress-5-5/ However, when doing so the VIP coding standards...

kopepasah

Review the WordPressVIPMinimum.Hooks.PreGetPosts sniff

3

Review the `WordPressVIPMinimum.Hooks.PreGetPosts` sniff for the following in as far as relevant to that sniff: - [ ] Code style independent sniffing / Correct handling of quirky code Typical things...

jrfnl

## What problem would the enhancement address for VIP? #415 dropped the file operations down from Errors to Warnings, but this is not the full picture. Here's a rundown of...

GaryJones

PHPCSUtils: Add dependency

3

## What problem would the enhancement address for VIP? Much of the logic in our sniffs does not account for certain code styles, more modern PHP syntax, and misses other...

GaryJones

We added detection for `exclude` in https://github.com/Automattic/VIP-Coding-Standards/pull/589... but in an attempt to avoid BC-break of error codes, we didn't port over post__not_in to the grouping.

rebeccahum