Improve flush_rewrite_rules warning

[mikeyarce]

trafficstars

What problem would the enhancement address for VIP?

Right now here's the rule that we see when you try to use flush_rewrite_rules():

🚫 Error( severity 5 ): flush_rewrite_rules should not be used in any normal circumstances in the theme code (WordPressVIPMinimum.Functions.RestrictedFunctions.flush_rewrite_rules_flush_rewrite_rules).

I feel like adding more context here as to "why" would be helpful, and also adding cases where this might be appropriate? For example, what about in a plugin activation/deactivation hook?

Describe the solution you'd like

1. Why should you not use it
2. When it might be ok to use
3. What the effect of using it would have
4. Link to a doc on docs.wpvip.com to more details

[pratik-londhe4]

Hi, I am getting this error in my plugin code when used in activation hook function. Is this expected ?