VIP-Coding-Standards

VIP-Coding-Standards copied to clipboard

AlwaysReturnInFilter: bow out on exit/die/throw ?

3

## Bug Description Generally speaking, functions hooked into filters should never throw exceptions or call `exit()` or `die()` and should always return a value. However, there are (valid) edge cases...

jrfnl

Sniff idea: Detect when constant is being used in constant()

3

## Describe the solution you'd like Not sure if VIPCS is the best way forward, but I think this would be a worthy sniff. When using `constant()`, we should throw...

rebeccahum

Update PHPUnit dependencies

1

https://github.com/Automattic/VIP-Coding-Standards/blob/796580706adaaf73a3a40e4c92a64dc9aaa0b700/composer.json#L29 We've had a customer report an issue with the PHPUnit version requirements in composer. Where up to version ^7 is required PHP 7 is required. They are trying to...

anigeluk

Add check for register_uninstall_hook

1

## What problem would the enhancement address for VIP? Because the contents of `/wp-content/plugins` and `/wp-content/themes` are setup as `read-only` directories on the VIP Go platform, admin users cannot uninstall...

terriann

## What problem would the enhancement address for VIP? Because the contents of `/wp-content/plugins` and `/wp-content/themes` are setup as `read-only` directories, and end-users can't install or update plugins from within...

terriann

NoPagingSniff: False negative when there is no comma after the parameter

1

## Bug Description There's a false negative when there's no comma after a single item array. For example, this will flag as expected: ``` $args = array( 'nopaging' => true,...

rebeccahum

Sniff for using PDO to connect to DB

1

## What problem would the enhancement address for VIP? The PDO_MYSQL module is not enabled on VIP. Plugins reliant on PDO like MailPoet are therefore currently not compatible with VIP....

ross-mulcahy

Review the WordPressVIPMinimum.Security.PHPFilterFunctions sniff

1

Review the `WordPressVIPMinimum.Security.PHPFilterFunctions` sniff for the following in as far as relevant to that sniff: - [ ] Code style independent sniffing / Correct handling of quirky code Typical things...

jrfnl

Add warning for list_files function and related

6

## What problem would the enhancement address for VIP? I've recently been doing a code review and noticed the `list_files` function had no warning attached. On VIP Filesystem, the `list_files`,...

ovidiul

Flag if Advanced Custom Fields plugin version is 4.*

2

## Describe the solution you'd like On https://docs.wpvip.com/technical-references/plugins/acf-5-and-vip-go/, we prohibit using any ACF version 4: > Please note that while ACF version 5 can be used on most VIP Go...

rebeccahum