Athish Pranav D
Athish Pranav D
@daipom i am not sure what is this issue ``` Failure: test_filter_key_not_exist(ParserFilterTest): in mock 'flexmock(Fluent::Test::Driver::TestEventRouter)': no matching handler found for emit_error_event("test", 1272942121, {"foo"=>"bar"}, #) Defined expectations: should_receive(:emit_error_event).with(String, Integer, Hash, #).once....
Got it @daipom Will make the changes in sometime
@daipom i have addressed the comments. Additionally i felt there was a redundant rescue in the prev code so i have removed that as well. Is it fine now?
@daipom thanks for this help. I had difficulty in figuring out the edgecases. Thanks for doing it along with this to make it move ahead
@daipom i have reverted the change with redundant rescue. Can you point out the change in the error messages if its still present in this pr?
@xavierleroy I am raising this issue and willing to work on it as well once you confirm. Incase if this feature is not appropriate please let me know asap
@xavierleroy thanks for the reply. I have already added an implementation in mirage-crypto so I guess adding it here won't be a problem
https://github.com/Athishpranav2003/mirage-crypto I added the implementation and tested it here. Will go ahead and add it to cryptokit as well
@xavierleroy could you please check this
Also, I will add comments once its verified. Sorry for not adding comments along with the code