Athish Pranav D

Results 95 comments of Athish Pranav D
trafficstars

@cosmo0920 addressed the comments

@cosmo0920 addressed the comments

@daipom i have raised this as a draft. This needs other changes like changing the tests around this, exception handling and etc. For now lets have discussion on the base...

@daipom thank you. The tests needs to be revamped for filter parser since the tests involve few instance variables. Do check it in freetime and let me know

@daipom any opinion on this logic? Should we go ahead with this?

@daipom yah I wanted to make sure we are in same page. I will refactor the code and change the error part after that

@daipom I guess the CI test fail is not related to this change

@daipom https://github.com/fluent/fluentd/blob/51b860b1be2eb59076d706fda12d55657a614c8f/test/plugin/test_filter_parser.rb#L659-L666 could you please point which emit_event is this call part of

After doing some verification https://github.com/fluent/fluentd/blob/51b860b1be2eb59076d706fda12d55657a614c8f/lib/fluent/plugin/filter.rb#L82-L104 The emit error event is in line 90/99. This implies that earlier we raise the exception in filter one record and capture in the filter...