Athish Pranav D

Results 95 comments of Athish Pranav D
trafficstars

@daipom did u get chance to look at this?

Its fine i guess, Even i was very busy in last 2 weeks :+1:

@daipom thanks for the review. Yah, this will kick a lot more changes in the overall events pipeline. For now i have just added the compression support as a module...

@daipom can you please check the change in the Compression module as well. Once if we merge this we can proceed with the other development around this

Sure @daipom If it's needed then I can split the PR into 2 where this will only focus on `zstd` and other one for `in-forward`

@daipom how to proceed in this PR?

``` bundle exec rake test TEST=test/plugin/test_compressable.rb 2856ms  Sun 03 Nov 2024 11:29:54 AM IST /usr/bin/ruby -w -I"lib:test" -Eascii-8bit:ascii-8bit /usr/share/gems/gems/rake-13.2.1/lib/rake/rake_test_loader.rb "test/plugin/test_compressable.rb" /usr/share/gems/gems/bundler-2.5.16/lib/bundler/rubygems_ext.rb:250: warning: method redefined; discarding old encode_with /usr/local/share/ruby/site_ruby/rubygems/dependency.rb:341: warning:...

I guess there is a small careless Problem is local testing is not working at all. Could help me with that later I will check after 18th Got packed with...

@daipom the gem issue got resolved after update,prolly some mismatched versions, All tests are passing now

@daipom some doubts here in chuck open method for decompress we dont have any type identification. how to identify the chunk type while open/read method is called https://github.com/fluent/fluentd/blob/78a7972bfe6b421f08472701f04f00515ed24bee/lib/fluent/plugin/buffer/chunk.rb#L201-L226