Ankita Swamy

/ok-to-test

@DiptoChakrabarty can you squash your commits?

@DiptoChakrabarty can you please run the tests locally and see the issue, it's something to do with these changes only.

> @Ankitasw based on the change I should add a test to check Subnet != asg.Subnet right ? Yes please.

> @Ankitasw based on the change I should add a test to check Subnet != asg.Subnet right ? Is this change yet to be done?

> the tests are failing because I set the machinePoolScope.AWSMachinePool.Spec.Subnets as []infrav1.AWSResourceReference{ { ID: pointer.String("subnet1"), }, { ID: pointer.String("subnet2"), }, }, and the existingASG.Subnets as []string{"subnet1", "subnet2"}, do they have...

@DiptoChakrabarty were you able to figure out the issue?

/remove-lifecycle rotten

@rvacaru Could you please sign the CLA and try again?

@rvacaru any progress with this?