Ankita Swamy comments

Results 305 comments of


                                            Ankita Swamy

rework vpc cni envvar logic to drop the forced keys

@richardcase @Skarlso i thinks folks are ok to merge this, shall we go ahead?

rework vpc cni envvar logic to drop the forced keys

/test pull-cluster-api-provider-aws-e2e-blocking

Fix typo in AWSManagedMachinePool UpdateConfig

> /remove-lifecycle stale I think we should keep lifecycle as is 😄 authors can take necessary action, maybe revive PR, or it will get closed automatically.

Fix typo in AWSManagedMachinePool UpdateConfig

Since we have v1beta2 APIs /unhold /lgtm /approve

Fix typo in AWSManagedMachinePool UpdateConfig

/hold /test pull-cluster-api-provider-aws-e2e until test passes.

Fix typo in AWSManagedMachinePool UpdateConfig

@phoban01 As verify job is failing, it requires `make generate` target to be run locally and then push the changes again.

Fix typo in AWSManagedMachinePool UpdateConfig

/unhold

docs: Steps to summarize all the options available in CAPA for the credentials to be used when we pivot to management cluster

/reopen

Allow for Self-Managed VPC with a Secondary Subnet for Pods

@luthermonson could you please fix unit tests `TestReconcileCniVpcCniValues` ?

Make optional API fields consistently pointers (or not pointers)

Just thinking out loud to help understand issue, below are the Pros and cons of using pointers: Pros: - If you need to modify something in the field we should...