Ankita Swamy

Results 305 comments of Ankita Swamy

I think functional options is better if we want to add more services later, in that way the implementation would be flexible and wont require huge changes everytime we add...

@richardcase I have questions regarding this implementation: - As mentioned in example, `NewClusterReconciler` should be used while controller creation in main.go. If that is the case, what opts we will...

Update: I got some idea after thinking out loud, maybe I will try it once and raise a WIP PR to get feedback.

> unmanaged clusters --> Cluster-API-managed clusters managed clusters --> EKS-managed clusters +1 for this renaming.

I have not followed this issue. cc @richcase if you know how this is related to updation of wrong providerIDList

@Skarlso Thank you for raising this issue. Since this particular doc is inherited from cluster-api project, do you mind raising this issue [there](https://github.com/kubernetes-sigs/cluster-api)?