Ankita Swamy
Ankita Swamy
@cnmcavoy it would be good to test this in E2E. could you please enable `EVENT_BRIDGE_INSTANCE_STATE` in https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/f23771b6b1cb6022e755c18d9f3f8d07465806fc/test/e2e/data/e2e_eks_conf.yaml and run the eks tests again? Otherwise, LGTM.
/test pull-cluster-api-provider-aws-e2e-eks
/lgtm /approve
/lifecycle active
/remove lifecycle-stale /lifecycle frozen
@sedefsavas then shall we wait for this change to merge before merging/starting integration tests for AWSCluster and AWSMachine controllers?
> No need to wait, we can refactor IMO. Yes, what I meant was we first need this refactoring and then rebase changes in integration tests and we need these...
@richardcase I can do it, if you have not started
@richardcase there are two options suggested in the issue, which one we should move forward with? I am ok with any of the approach.