Alan Rominger

I have not tested it (and much could be wrong), but I envision something like this https://github.com/psycopg/psycopg/compare/master...AlanCoding:yield_timeouts?expand=1, and this would be applied `AsyncConnection.notifies` method as well.

Without more information, I'm hesitant about merging this diff. What consistency does this add? Other cases we use `name` includes this, which is the _play_ name. https://github.com/ansible/ansible-runner/blob/a3a7d1f003996fe7c757436b021d54f4a84aa4c6/ansible_runner/display_callback/callback/awx_display.py#L506-L508 I do see...

We should add some regression test coverage, but :+1: this looks good.

The encoder class is pretty self-aware that it duplicates the Ansible-core version, in its doc string: > The class AnsibleJSONEncoder exists in Ansible core for this function this performs a...

The current design is very ill-suited for capturing the image pull time. You could get the started time from the started callback and then measure difference between that callback and...

Yeah, it could be the bug that https://github.com/ansible/awx/pull/14572 is trying to fix. The introduction of the bug https://github.com/ansible/awx/commit/f5922f76fa852fde2336fcd69c6db630ff8e72b7 made it into the last release.

I'm more than happy to accept this statement > this does not really belong in the plugin but as a more general vault option, as 'unvaulting' can happen at other...

In my last comment, I gave a [proposed solution](https://github.com/AlanCoding/Ansible-inventory-file-examples/tree/master/vault/file_vars), which has a corresponding patch in Ansible core https://github.com/ansible/ansible/pull/78765 If Ansible core were to accept that patch (even in principal) then...

Turning off vars plugins will drop unrelated variables. That would work for _some_ users. The user pain here is that they vault a _file_ in `group_vars/` or `host_vars/` and this...

> import with vault secrets, but do not unvault the data, basically convert the vaulted files into individual inline vaults (also requires changes) It sounds like that would be the...