ansible-runner icon indicating copy to clipboard operation
ansible-runner copied to clipboard

make callback event_dict fields consitent

Open valbendan opened this issue 3 years ago • 2 comments

add name field to event_dict to make callback event_dict fields more consitent (intended to fix missing name field)

valbendan avatar Feb 18 '22 13:02 valbendan

Without more information, I'm hesitant about merging this diff. What consistency does this add? Other cases we use name includes this, which is the play name.

https://github.com/ansible/ansible-runner/blob/a3a7d1f003996fe7c757436b021d54f4a84aa4c6/ansible_runner/display_callback/callback/awx_display.py#L506-L508

I do see other cases where we put in the task name, but all of those cases look rather duplicated with the task key. For a problem that like, I would prefer to put up a notice to deprecate the ambiguous field in favor of the other field.

AlanCoding avatar Apr 18 '22 14:04 AlanCoding

@valbendan Could you please address the https://github.com/ansible/ansible-runner/pull/1005#issuecomment-1101444040? Thanks.

Akasurde avatar Mar 15 '23 05:03 Akasurde