Tim Condon

Results 525 comments of Tim Condon

Nothing to see here 😆

@tanner0101 yeah an AuthKit and FluentAuth package would make sense. I think accepting vapor/auth as an auth layer for Fluent as it currently stands would be wrong as there's lots...

Hmm for some reason I thought I'd be able to commit the suggested change! I don't think I can but will merge once it's done

Yeah this isn't getting merged. I've just run the performance tests locally. Current implementation took 25s to run them all. This PR took 5 minutes and 19 seconds. We could...

You need to change the configuration to release to actually enable the performance tests - you can see they all took 0.01s because they were ignored by https://github.com/vapor/routing-kit/blob/master/Tests/RoutingKitTests/RouterPerformanceTests.swift#L132

Allowing changing the router should be allowed. Note that you can only have one dynamic parameter for a path component - your example of `/products/:id` and `/products/computers` works fine

@ULazdins we could expose another initialiser on `DefaultResponder` that allows you to pass in your own `Router`. Due to the associated type on `Router` though they are pretty coupled

Yeah I think that's probably the best way. I have no problem opening up `DefaultResponder` if there's a use-case for it. What are your thoughts @gwynne @calebkleveter @jdmcd @MrLotU since...