routing-kit icon indicating copy to clipboard operation
routing-kit copied to clipboard

Published 20 hours ago • verified publisher icon vapor

Downstream Introduced

Open twof opened this issue 5 years ago • 4 comments

twof avatar Oct 26 '20 16:10 twof

Due to changes made to Sources/RoutingKit/Parameters.swift, you may need to make updates to the following: https://docs.vapor.codes/4.0/routing/ https://docs.vapor.codes/4.0/content/

github-actions[bot] avatar Oct 26 '20 17:10 github-actions[bot]

This is cool!

0xTim avatar Nov 02 '20 10:11 0xTim

I think this is a great thing to try - will let the other core team member chime in

Darn it, Tim, now we have to try to figure out whether it's me or @siemensikkema you're implicitly refusing to acknowledge with your so-totally-not-a-typo singular noun... 🤣

Joking aside, I agree - let's see how it goes. I'm just holding my "Approve" review until I have a chance to suggest some minor improvements to the GH Action workflow, which I'll do shortly.

gwynne avatar Nov 02 '20 10:11 gwynne

I was going through some old stuff and found out this was still open. @gwynne still want to make improvements?

twof avatar Jun 23 '22 20:06 twof

@twof Remind me what this was supposed to actually do? 😅

gwynne avatar Mar 20 '23 12:03 gwynne

@gwynne the goal of downstream was to loosely bind source files to documentation, so developers can be alerted that documentation changes may be required to go along with their code changes.

twof avatar Mar 26 '23 01:03 twof

@twof As it turned out, I eventually thought to actually look at your code- after having already asked, of course 😆 With the new DocC support @0xTim's been adding, this is probably not a direction we'll end up going.

And even aside that, this PR was pretty ancient, not to mention the last one open on routing-kit, so I took the opportunity to get at least one of Vapor's repos down to zero open issues and PRs 😅

gwynne avatar Mar 26 '23 02:03 gwynne