Tim Condon

Results 525 comments of Tim Condon

@micezhao The RediStack package is hosted on Gitlab as that's where the development is done - this repo is just a mirror. Can you clone the package directly from Gitlab?

What's this in response to? I know several projects that this will break the build for so I'd say the bar will be pretty high for a source breaking change

Not to mention [every project built using the template](https://github.com/vapor/template/blob/main/Tests/AppTests/AppTests.swift)

Maybe we can gate this with a 5.7 flag so it only breaks if running with 5.7

@dmonagle are you still seeing this error? I think we decided to not go ahead and merge this and I haven't had any errors in my apps

(Pressed the wrong button but might as well keep it - feel free to ask for it to be reopen if you want!)

I'm confused - what's the problem? We do pass the source through for DebuggableErrors https://github.com/vapor/vapor/blob/main/Sources/Vapor/Logging/Logger%2BReport.swift#L22

Right I see. Is this actually causing an issue? Because we're logging file, function and line

@clayellis I agree the `async*` prefixes are laborious to say the least. But we don't want to break the public API until Swift 6 which means we can't just change...