zzak

Remove approval block to run tests, lint, and annotations

2

These steps are designed so any code executed from the workspace happens inside an unprivileged docker container. We would get faster feedback on PRs if these run instantly.

For example, we can configure actioncable to run it's tests on Chrome and Firefox in the container: https://github.com/rails/rails/compare/main...zzak:rails:cable-on-image-browsers-integration-test ``` # just how I setup my rails for testing $ cd...

Fix `remove_foreign_key` when multiple columns are found

6

Fixes #55078 This PR has been updated to fix the behavior using 8.1 migration for backwards compatibilty. /cc @kei-s

Use updated Sidekiq wrapper class name in test

2

This is due to sidekiq/sidekiq@4d80a26 changing the name used when queueing jobs. /cc @yahonda @seuros

Allow configuring Active Storage base controller parent class

2

This enables users to change the parent class for ActiveStorage::BaseController, including the option to inherit from ActionController::API for api-only apps. Fixes #32208 Rebase of #32238 with tests and using the...

feat: make `deep_merge` a soft-requirement

2

The goal here is to remove deep_merge and rely entirely on ActiveSupport's `Hash#deep_merge` implementation. This does mean that if you want to keep the existing behavior, or rely on DeepMerge's...

[3-2-stable] Add `HostAuthorization` rack-protection middleware (#2053)

1

The Sinatra project received a security report with the following details: > Title: Reliance on Untrusted Inputs in a Security Decision > CWE ID: CWE-807 > CVE ID: CVE-2024-21510 >...

Variation of #2092 rebased on the `v4.0.0` tag.

Restore Rack v2 support

5

In 8a17d4b we dropped support for Rack 2 while adding support for Rack 3, so there was no transition period where both were supported. Then when we released cd3e00d to...

Remove circular require for resque from resque-scheduler

1

This resolves the following warning: ``` BUNDLE_GEMFILE=test/gemfiles/Gemfile-rails-main bundle exec rake test:activejob /home/zzak/.rbenv/versions/3.3.5/bin/ruby -w -I"lib:test:lib:test/active_job" /home/zzak/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/rake-13.2.1/lib/rake/rake_test_loader .rb "test/active_job/cases/adapter_test.rb" Using resque /home/zzak/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75: warning: /home/zzak/.rbenv/versions/3.3.5/lib/ruby/3.3.0/bundled_gems.rb:75: warning: loading in progress , circular require considered...