zyy17
zyy17
In current implementation, the `btf` mod is [private](https://github.com/libbpf/libbpf-rs/blob/master/libbpf-cargo/src/lib.rs#L67). I think it would be helpful if we expose btf module. I found the similar PR but closed for some reason: https://github.com/libbpf/libbpf-rs/pull/62/files#diff-fa4e7373a6c4a1948a89dc3be8086e734bea95eb7a4f5c5f24d7bd24feb73988....
I think `i:` is unnecessary: https://github.com/logcabin/logcabin/blob/master/Storage/Tool.cc#L59
I use `redis3m` as git submodule in my project: ``` $ tree -L 1 ch1/ ch1/ ├── build ├── CMakeCache.txt ├── CMakeFiles ├── cmake_install.cmake ├── CMakeLists.txt ├── gtest/ ├── main.cc...
If we use `--config-file` to start our service, we don't set the default values(if the value is not set by the config file, set it as the default value). I...
## Minimal reproduction ### Code version Use branch `feat/distribute-poc` ### Examples ``` cargo run -- metasrv start --store-addr=127.0.0.1:2379 cargo run -- datanode start --rpc-addr=0.0.0.0:4100 --http-addr=0.0.0.0:4101 --mysql-addr=0.0.0.0:4102 --postgres-addr=0.0.0.0:4103 --node-id=1 cargo run...
I hereby agree to the terms of the [GreptimeDB CLA](https://gist.github.com/xtang/6378857777706e568c1949c7578592cc) ## What's changed and what's your intention? - Remove GitHub Container Registry; It's no need to maintain multiple container registry...
### What type of enhancement is this? Refactor ### What does the enhancement do? The current project exist some typos, we can use the [typos](https://github.com/crate-ci/typos) to find out all of...
I hereby agree to the terms of the [GreptimeDB CLA](https://gist.github.com/xtang/6378857777706e568c1949c7578592cc) - fix nightly build error of missing git tag, the error message is in [5864923014](https://github.com/GreptimeTeam/greptimedb/actions/runs/3501105200/jobs/5864923014); - fix typo; Please explain...
### What type of enhancement is this? Refactor ### What does the enhancement do? For maintaining code quality, we need the nightly build and test: - nightly release - nightly...
### What type of enhancement is this? Refactor ### What does the enhancement do? Since the rust code is growing fastly, the building process will get slower. We can use...