zyy17
> Is it possible that we may print sensitive data into slow log file? Like `copy from/to` statements usually take a long time, while bearing AK/SK info. We already use...
> Just realized that if user doesn't edit their config toml to remove this `mode`, will we throw an error for this "unknown" config item? > > If so, this...
> serde typically ignores unknown fields. Do we assert unknown fields to failure anywhere? You are right. @sunng87, the `Mode` on the frontend is not always necessary for our released...
Suggestion: The original image can be built once and copied anywhere, it will make the CI code simple and easy to read.
@leaf-potato, just ping you to ask about any progress.
I think we can create a `examples/` in the root directory.
@leaf-potato it's yours. Have fun. Feel free to ask if anything needs to be clarified.
> The version uses the `branch-commit` format. When git checkout to a commit, there is no branch. > > https://github.com/GreptimeTeam/greptimedb/blob/93be81c0410a32f8955769599090de0f4f11e73f/src/common/version/src/lib.rs#L127-L129 > > Therefore, fix it by using commit id directly...
> > I'm confused with `short_version`(`CARGO_PKG_VERSION`) and `version`(`${commit_short}-${branch}`). In fact, `version` is some kind of "short" version. > > Mabey it's a bug. When calling the `log_version` function, pass the...
@raju130404 It's already resolved in https://github.com/GreptimeTeam/greptimedb/pull/4572.