Jiashun Zhu

Results 33 comments of Jiashun Zhu

主要用在什么场景?如果上下游都是brpc,可以用https://github.com/apache/incubator-brpc/blob/master/docs/en/streaming_rpc.md

> 可以通过给客户端socket设置SO_KEEPALIVE参数来实现。开启keepalive操作系统会来探活然后关闭已经断开的socket。 > > ```c++ > if (setsockopt(client_fd, SOL_SOCKET, SO_KEEPALIVE, &val, sizeof(val)) < 0) { > ... > } > ``` > > 对代码侵入性比较小。另外可以把把TCP_KEEPIDLE、TCP_KEEPINTVL、TCP_KEEPCNT三个socket选项的值提供给Channel设置。 让用户自定义探活动时间 > > ```c++ > if...

https://github.com/apache/incubator-brpc/pull/1657 was merged.

``` [ RUN ] RecorderTest.latency_recorder_qps_accuracy bvar_recorder_unittest.cpp:240: Failure Expected: (0.1) > (read(lr1, 10/2.0)), actual: 0.1 vs 0.191 ``` 看起来是slow test的问题,把expectation value改一下?

看了下主要是两个地方: ``` I1026 15:17:31 5891 bthread_butex_unittest.cpp:61] Joined thread 4294969088 at 232338us [0] Expected: (labs(elp - (th - (bthread_t*)arg + 1) * 100000L))

> > @wwbmmm 伟冰,这个内部有相关开发吗? > > 有,但是这个对brpc框架的改动较大,目前还没想好应该如何合入社区 > 目前内部也还在初步验证的阶段,待成熟之后再考虑开源吧 好的,谢谢同步

Could you write something more about how you tested the code? For example, what's the difference in UI before and after?

so which one is the latest? https://github.com/apache/incubator-brpc/pull/1031 or https://github.com/apache/incubator-brpc/pull/1026?

@hairet Thanks for uploading the latest version.