zxq82lm
zxq82lm
> This is quite a large amount of code to review. Naively looking at the desired feature, I would hope it ended up being a relatively straight forward modification to...
> @zxq82lm thanks for the rundown. I'm doing some generic testing now before looking closer at the code. Overall the multi-window stuff is awesome. Great work! > > I am...
> Is it happening just with i3, or also the default Ubuntu window manager? Probably reproduced with the default Ubuntu window manager (still investigating).
> @zxq82lm I see you pushed some more commits. Just let me know when this is ready for another look. Sure, still analyzing the issue. I’ll let you know as...
@codex analyze this PR.
> [@zxq82lm](https://github.com/zxq82lm) looking at the issues linked [here](https://docs.rs/notify/latest/notify/index.html#editor-behaviour) gave me an idea. > > What if instead of writing directly to the KDL files, we wrote to temporary files then...
On both macOS and Linux, when the editor loads I see the navigation gizmo appear briefly over-zoomed and centered (like in the screenshot) for about a second, then it snaps...
Open question: should the locked x-axis timestamp also be serialized? If so, should it be recorded on every locked graph, or only on the leader graph that owns the lock?
> Hmm, by timestamp do you mean the range of time that the graph represents? Right. By "timestamp" I meant the X-axis window we’re locking (the pan/zoom offset). We should...
I opened a PR to fix this: #703.