Jason A. Donenfeld
Jason A. Donenfeld
Oh, good point. Fixed: https://git.zx2c4.com/wireguard-go/commit/?id=2ef39d47540c4537f0ddd3355fb95b33b91c09b7
Yalright, well, just let me know when it's finally done with no TODOs left, and I'm happy to review it.
> @danderson this is I think entirely self-contained so shouldn't need much review. Config semantics are important and this code seems pretty half-baked (there's a "TODO: this is broken, remove...
Punting to @crawshaw to address.
Thanks. I certainly welcome this effort. It's much overdue. One thing I'm wondering: do sticky sockets actually still work?
> I haven't tried out sticky sockets yet (I didn't bring my linux machine and haven't set up another one yet), but I don't think it blocks this commit. That...
This exposes a lot of internal machinery of WireGuard that isn't meant to be exposed. Are we sure we should be giving this to the user?
Okay. Let's hold off on merging this for a bit until we can fully study the use case. I'm very hesitant to introduce extensive internal apis without thinking about network...
An progress here? @bchatelard
@hroi Ping?