Jason A. Donenfeld
Jason A. Donenfeld
Hey @koalaman - might I poke you about this? Namerefs are an important feature of bash.
This also cleans up a leaked notify. Thanks. Merged.
I'm actually going to unmerge this, in hopes that https://git.zx2c4.com/wireguard-go/commit/?id=45916071ba13c8f6ec44dfc46bda0449d2d54a9f is actually the more proper fix. If it's still broken I'll remerge this.
Why not turn this on by default? (`+sixel`) Or just always turn it on? It doesn't seem to add a dependency.
So the thing I don't like about this is that it's actually kind of well designed! Specifically, this `wgctrl.New(wgctrl.WithShim)` business. That's a very weird thing to complain about so let...
FWIW, this seems like a pretty bad change. I don't mind following .NET, but doesn't this seem awfully brittle? You can just make your parent process named 'services.exe' and trick...
I left some comments on here. How safe is this clientSideEncryption and deviceToDeviceTransfer business? Can these be abused? Is this something we want on by default?
Thanks for this patch. And sorry it's taken so long to review it. I left some comments for @gergely-sallai or @tturner to address. One question: why not just have a...
Wondering how to repro this. Do you run gradle from a different CWD or something?
Well, there are two other GLOBs in there that aren't doing this. So that's a bit puzzling. I think I'd like to see some analysis of what's happening here. AFAICT,...