Zvi Schneider
Zvi Schneider
@madolson wrote a more elaborated overview in the [top comment](https://github.com/valkey-io/valkey/pull/692#issue-2371940425) please let me know if it helps reading through this change
> It's a lot of code that I don't understand. Is it basically the same logic that we used to have in our patched jemalloc that is converted to use...
Will post a PR with fixes to existing comments later this week
forced push by mistake
@madolson , @zuiderkwast , @ranshid, I [created a new PR](https://github.com/valkey-io/valkey/pull/1266) with current code and a [separate commit](https://github.com/valkey-io/valkey/pull/1266/commits/8f7680eeb9477c24d7b280130ab5e87a1b9f26b7) for CR fixes. Seems I used wrong update method (rebased) and I could...
I think we could do something better here. If we separate the memory by usage we can have different lock policy for different memory usages. We than can, for example:...
sounds like ideally the expiry logic should be embedded into the dict itself [and than can be easily reused for all dict users], have we evaluated such an option? [instead...
Thanks @madolson for sharing, I'll take a look. I think with resonable assumptions it could be easier. The assumptions are about how tight do we want to be on eviction...
Didn't read the discussion, resonding only with respect to the calloc... > I am aware of how anonymous allocation works, but I am not sure how JEmalloc is operating it...