Zvi Schneider

Results 19 comments of Zvi Schneider

@lipzhu the update of used_memory has 2 cost aspects, the zmalloc_size and also the fact it's an atomic operation. 1. regarding `zmalloc_size` cost: it is actually called twice, once in...

> Am I wrong in assuming we get more fragmentation when I/O threads are used? I don't think this is true for most cases. By default we do not use...

> At AWS, we very rarely see places where defragmentation is actually useful. Most of the time, new data is getting added and removed at about the same rate and...

@PingXie here is the followup https://github.com/valkey-io/valkey/pull/692

This change makes sense to me overall and tradeoffs are good. My concern is with that conceptually it's not a good idea that we have 2 conflicting patterns: 1. use...

> This change makes sense to me overall and tradeoffs are good. > > > > My concern is with that conceptually it's not a good idea that we have...

Just to comment on the performance aspect [even if we ignore the different type issue @PingXie mentioned]. I've seen many cases where inlining is not working as good as we...

> > `maxmemory-clients 100%` means when all clients' memory reach 100% maxmemory, valkey will disconnect some clients, this config doesn't influence data eviction directly. > > I have always wished...

@PingXie , Thanks. My only concern with waiting for 8.2 is that I have several followup improvements to defrag mechanism that will be delayed as a result. The changes are...

> @zvi-code When we release Valkey 8.0.0-rc1, we create the 8.0 branch, and we continue to merge new features into unstable. There is no freeze of the development. You will...