Aleksej Vukomanovic comments

Results 128 comments of


                                            Aleksej Vukomanovic

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users that already have ACR tiles set up

I increased estimate for a point since this issue will require interacting with existing conditionals for 2 previous banner variations, and during testing it should be monitored that this variation...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users that already have ACR tiles set up

@eugene-manuilov thanks, IB updated

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users that already have ACR tiles set up

@eugene-manuilov Thanks, IB updated

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users that already have ACR tiles set up

> ITEM 1: Testing on the first scenario of the QAB, where I set up through tailored metrics, withou You are correct, we should still show Add metrics CTA in...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users that already have ACR tiles set up

@kelvinballoo > ITEM 1: ⚠ Unfortunately, I still see the 'View metrics' CTA even after I reset site kit. I tested on main branch and dev branch but both yield...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users with manual set up

Thanks @eugene-manuilov I updated IB to list the contexts > Which conditions? The ones from the next point? I expanded on this sentence to clarify that it should apply for...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users with manual set up

@eugene-manuilov Thanks, updated. > I think we can probably re-use the notification component from https://github.com/google/site-kit-wp/issues/9371 because it has similar content, right? Yes that's the idea, that component will be reused...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users with manual set up

@eugene-manuilov THanks, IB updated

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users with manual set up

@kelvinballoo To chip in here, since you have the tester plugin I sent you, you won't need to use tweak, surfacing the callout by forcing the events will suffice, since...

Expand the logic of the `ACRNotificationCTAWidget` component for existing KMW users with manual set up

@kelvinballoo Thanks for you observations. I can answer items 1 and 3: > ITEM 1: ⚠ When clicking on 'Maybe Later' (Dismiss), the banner will disappear as expected. However, after...