Aleksej Vukomanovic comments

Results 128 comments of


                                            Aleksej Vukomanovic

Fix issue where VRT tests fail before all screenshots are captured

Not seeing what can be the cause, since I this seems to be CI related, locally it doesn't fail. Unassigning myself

t.every is not a function

@tofumatt Ah indeed, you are right. Not sure why I went with longer route. IB updated

Add Google Analytics page views count to WP Admin's Posts list view.

@eugene-manuilov Thanks for the feedback. Originally I though it might be more handy to make this class more decoupled for flexibility as it would have access to the `$modules` which...

Improve the layout of the graphic on the Consent Mode Setup CTA Banner at narrow desktop viewports.

Thanks for raising it @mohitwp . It is most likely written by mistake/typo during AC, as we usually consider tablets starting _from_ 600px not bellow, it is already mobile bellow...

Use the `useInViewSelect()` hook where applicable in the Audience Segmentation feature

@benbowler @nfmohit Just to chip in, `useInViewSelect` has been modified to expect direct dependencies in #8789 which will be merged soon, it is worth to mention it as part of...

Fix glitches when closing various modal dialogs

I detected the reason for button being broken after clicking outside the Modal. But focus not getting back to the button that triggered it is pretty weird occurrence. What I...

Add logic to trigger modal once user input questions have been updated

@eugene-manuilov makes sense, thanks. I updated IB to reflect this approach

Decouple module-specific effects from core components

@eugene-manuilov Thanks for the feedback/clarification and new route suggestion. I updated IB to reflect that approach.

Decouple module-specific effects from core components

@eugene-manuilov Thanks, IB updated

Implement a new modal component showing current vs new tailored suggestions

Thanks @eugene-manuilov IB updated, reference to the UI state has been removed, the default props will control the dialog state