Junfan Zhang comments

Results 434 comments of


                                            Junfan Zhang

YARN-11736. Enhance MultiNodeLookupPolicy to allow configuration of extended comparators for better usability.

> @zuston Thanks for the feedback. > > > Oh, I will we encoutered the similar problems about multi node placement about different resource spec. And I found some bugs...

[FEATURE] Add NettyMemoryMetrics for netty client and server

Sounds good.

YARN-11112 Avoid renewing delegation token when app is first submitte…

@dineshchitlangia @9uapaw @brumi1024 If u have time, could u help review it? I think it's a nice improvement.

[#2317] feat(server): Introduce server flush benchmark

Nice improvement. BTW, is it possible to introduce the feature of general end to end benchmark test, like using the client to create the fake data to send shuffle-server and...

[#2317] feat(server): Introduce server flush benchmark

> > Nice improvement. > > BTW, is it possible to introduce the feature of general end to end benchmark test, like using the client to create the fake data...

[#2300][Bug] Long tail tasks in the Write Stage retry phase results in data loss.

Sorry for the late reply, I'm busy for my work.

[#2111] improvement(client): cleanup the useless shuffle server clients when unregister shuffle

Sorry the late review and I think i missed this thread. @xianjingfeng

[#2062][FOLLOWUP]Improvement(dashboard): Display detailed info for application in dashboard ui

This looks a huge change, could you help check this? @maobaolong If this has been applied in your internal cluster, please let me know, this will strength my approval confidence.

YARN-11691. Add HTTP POST method to yarn web proxy servlet

LGTM. It's a case that flink encounters. Please take a look @slfan1989 .

[Improvement] Quickly delete local or HDFS data at the shuffleId level.

> @zuston Could you help me review this pull request? Yes, I will review this in the later 3 days.