Junfan Zhang comments

Results 434 comments of


                                            Junfan Zhang

[#1554] feat(spark): Fetch dynamic client conf as early as possible

Could you help resolve the conflict? @EnricoMi

[#1222] feature(rust): Create mini rust server to integrate spark tests

> Hi @zuston Can you please help review this pr? Thanks Sorry for the late reply, I'm still in vacation and I think I will review this on next week.

[#1222] feature(rust): Create mini rust server to integrate spark tests

Could you help fix this CI failure and update the description? I think the code looks OK for me, that we could push this forward assp. If something need to...

[FEATURE] support shuffle partition data read from multiple shuffle servers

Having any process on this? @dingshun3016

[FEATURE][Spark] Support partial sort and combine for reducing shuffle data size

I encounter this problem in our online jobs, but I don't dig into it. Anyway, from my side, this feature is an improvement. cc @xianjingfeng @advancedxy @jerqi

[FEATURE][Spark] Support partial sort and combine for reducing shuffle data size

> You mean map side combine? Yes > If we are going to support this feature, maybe a lot of client side code should be rewrote...😇 Yes. 🙆

[FEATURE][Spark] Support partial sort and combine for reducing shuffle data size

> any plan to support it? haven't. If you want this, feel free to discuss more

[FEATURE][Spark] Support partial sort and combine for reducing shuffle data size

The client and server side merge are all needed.

[#1304] Improvement(rss-client-mr): Using configOption in RssMRConfig

Could you help review this? @zhengchenyu

[FEATURE][Spark] Support partial sort and combine for reducing shuffle data size

> I think the merging should work on the client side, not on the RSS server. I think the zheng's design motivation is not same with you @KnightChess , if...