incubator-uniffle icon indicating copy to clipboard operation
incubator-uniffle copied to clipboard

[#1222] feature(rust): Create mini rust server to integrate spark tests

Open wenlongbrother opened this issue 1 year ago • 10 comments

What changes were proposed in this pull request?

Create a mini rust server to integrate spark tests, test heartBeat、sendData、register、unregister、requireBuffer、clearResource.

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: # (issue)

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

wenlongbrother avatar Jan 24 '24 13:01 wenlongbrother

Hi @zuston , could you please take a look whether it is met expectation?

wenlongbrother avatar Jan 25 '24 10:01 wenlongbrother

Hi @zuston , could you please take a look whether it is met expectation?

Just take a look. Overall LGTM.

zuston avatar Jan 26 '24 08:01 zuston

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59aa30d) 54.17% compared to head (8a82499) 55.15%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1481      +/-   ##
============================================
+ Coverage     54.17%   55.15%   +0.98%     
  Complexity     2822     2822              
============================================
  Files           435      415      -20     
  Lines         24501    22140    -2361     
  Branches       2074     2074              
============================================
- Hits          13274    12212    -1062     
+ Misses        10397     9169    -1228     
+ Partials        830      759      -71     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 09 '24 04:02 codecov-commenter

Test Results

 2 445 files  +  8   2 445 suites  +8   4h 47m 31s :stopwatch: + 5m 11s    823 tests ±  0     822 :white_check_mark: +  1   1 :zzz: ±0  0 :x: ±0  10 310 runs  +568  10 295 :white_check_mark: +568  15 :zzz: +1  0 :x: ±0 

Results for commit 4f63a5d3. ± Comparison against base commit 59aa30d3.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 09 '24 06:02 github-actions[bot]

Hi @zuston Can you please help review this pr? Thanks

wenlongbrother avatar Feb 10 '24 10:02 wenlongbrother

Hi @zuston Can you please help review this pr? Thanks

Sorry for the late reply, I'm still in vacation and I think I will review this on next week.

zuston avatar Feb 16 '24 03:02 zuston

Hi @zuston Can you please help review this pr? Thanks

Sorry for the late reply, I'm still in vacation and I think I will review this on next week.

Sure.

wenlongbrother avatar Feb 22 '24 09:02 wenlongbrother

Hi @zuston , could you please take a look and help review again? Thanks

wenlongbrother avatar Feb 23 '24 11:02 wenlongbrother

Overall LGTM. But I'm thinking whether having a general way to assign all existing spark tests for this riffle implementation.

Yes, I think so, if we have a general way, it will much easier to write new test. Do you have any suggestion?

wenlongbrother avatar Feb 25 '24 08:02 wenlongbrother

Could you help fix this CI failure and update the description? I think the code looks OK for me, that we could push this forward assp. If something need to be optimized, the further PR is welcome.

Sorry for the late reply, that I'm suffering from the hard work. 😅

zuston avatar Feb 29 '24 03:02 zuston