incubator-uniffle
incubator-uniffle copied to clipboard
[#1222] feature(rust): Create mini rust server to integrate spark tests
What changes were proposed in this pull request?
Create a mini rust server to integrate spark tests, test heartBeat、sendData、register、unregister、requireBuffer、clearResource.
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, describe the bug.)
Fix: # (issue)
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
- Change in user-facing APIs.
- Addition or removal of property keys.)
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
- If you add a feature or fix a bug, add a test to cover your changes.
- If you fix a flaky test, repeat it for many times to prove it works.)
Hi @zuston , could you please take a look whether it is met expectation?
Hi @zuston , could you please take a look whether it is met expectation?
Just take a look. Overall LGTM.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
59aa30d
) 54.17% compared to head (8a82499
) 55.15%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1481 +/- ##
============================================
+ Coverage 54.17% 55.15% +0.98%
Complexity 2822 2822
============================================
Files 435 415 -20
Lines 24501 22140 -2361
Branches 2074 2074
============================================
- Hits 13274 12212 -1062
+ Misses 10397 9169 -1228
+ Partials 830 759 -71
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test Results
2 445 files + 8 2 445 suites +8 4h 47m 31s :stopwatch: + 5m 11s 823 tests ± 0 822 :white_check_mark: + 1 1 :zzz: ±0 0 :x: ±0 10 310 runs +568 10 295 :white_check_mark: +568 15 :zzz: +1 0 :x: ±0
Results for commit 4f63a5d3. ± Comparison against base commit 59aa30d3.
:recycle: This comment has been updated with latest results.
Hi @zuston Can you please help review this pr? Thanks
Hi @zuston Can you please help review this pr? Thanks
Sorry for the late reply, I'm still in vacation and I think I will review this on next week.
Hi @zuston Can you please help review this pr? Thanks
Sorry for the late reply, I'm still in vacation and I think I will review this on next week.
Sure.
Hi @zuston , could you please take a look and help review again? Thanks
Overall LGTM. But I'm thinking whether having a general way to assign all existing spark tests for this riffle implementation.
Yes, I think so, if we have a general way, it will much easier to write new test. Do you have any suggestion?
Could you help fix this CI failure and update the description? I think the code looks OK for me, that we could push this forward assp. If something need to be optimized, the further PR is welcome.
Sorry for the late reply, that I'm suffering from the hard work. 😅