Zach Sherman

Results 133 comments of Zach Sherman
trafficstars

We didn't catch this in newer versions because there is a try and except exception catch

It seems the issue is mpl2nc is producing files with barely anything in them.. ``` xarray.Dataset Dimensions: profile: 0 Coordinates: (0) Data variables: unit (profile) uint16 ... Indexes: (0) Attributes:...

@EWolffWX Thanks for the PR! Next steps would be to include the function in the `__init__.py` in the retrieval module. We will want to add unit tests as well.

@EWolffWX No worries at all! And the neat thing with the PR system is, if you do the init change to your branch that you are using for the PR...

@EWolffWX I think I have time this week to work on this, did you perchance have a specific file you were testing the code on? I figured we can use...

@EWolffWX Did you by chance have an example or specific date of the file you were testing on? Was going to see if I can write up some unit tests....

@EWolffWX No worries and thank you! I can see if I can get some tests going. For the example, if your willing to put together a python file called, plot_storm_relative_velocity.py...

@EWolffWX Apologies for the late response. The testing I can work with that file you provided. I might just need help confirming the return values look correct. Besides that, just...

Also do you have an example direction and U and V you were testing @EWolffWX for that file? I was going to use those parameters for the unit tests.