zshuang0316

Results 6 comments of zshuang0316

@coderabbitai help could you guide me how to re-run the failed checks? I think they should not relate to my change.

Hello @cosmo0920, could you please help on the failed linux check which should not related to the code change? Thanks!

> I'd like to see a unit test for it though ideally. Sure, added.

@patrick-stephens Any other concerns?

> I supposed that this unit test contaminates for unit testing layer. Instead, extracting as win32 utility file for glob and unit testing with internal test would be fine to...

> Oh, our commit linter complains prefix issue in your commit: ❌ Commit [59cd7bb](https://github.com/fluent/fluent-bit/commit/59cd7bbdd332b05e750573c06e2bd8d49cae7841) failed: Subject prefix 'in_blob:' does not match files changed. Expected one of: CMakeLists.txt:, build:, glob:, in_blob:,...