Felföldi Zsolt

Results 13 comments of Felföldi Zsolt

> Doesn't compile? Indeed, last commit had a missing bracket, fixed.

@rjl493456442 I changed to block variable declarations in many places, in some places it obviously made the code look nicer, in some cases I wasn't totally sure, so please PTAL,...

While rebasing to latest master I also squashed a lot of commits that seemed to have resolved previous issues a while ago, in order to avoid total chaos and painful...

Also note that I moved `core/beacon` into `beacon/engine` according to Gary's suggestion. This touches many other parts of the codebase, `beacon.` prefixes have also been replaced to `engine.`. I think...

Replaced by https://github.com/ethereum/go-ethereum/pull/26874

> Is the intention to merge the subcommand or to convert into a flag for geth? I'd prefer to have both eventually. We definitely should have it as a flag...

> For reference, I was only ever able to run this using `https://www.lightclientdata.org`. It seems the required functions are not provided by CLs by default. Indeed, this tool requires a...

@FrankSzendzielarz this proposal was partly inspired by your review: https://github.com/ethereum/devp2p/issues/70 (I am not planning to implement the protocol format changes right now, just the overload protection part, but this is...

This is not a bug, it's a feature :) The error string "beacon syncer reorging" comes from `eth/downloader` and has nothing to do with the beacon light client. It just...

> Yesterday I processed the block range from around 12,000,000 to head multiple times, with history.logs unset (so I assume 90k). The default indexed history for both transactions and logs...