Rose

Results 19 comments of Rose
trafficstars

Can you document what the migration would look like to workaround this removal? We pass history to routes in other modules. It's a huge/breaking change across a bunch of our...

> @zoobot Change-type needs to be the last line.. I believe, otherwise no-bueno. Also, if the tests pass - just self-certify it, otherwise it will never get merged. Especially since...

https://github.com/moby/moby/pull/29376 https://github.com/moby/moby/pull/36054 It looks like balena-engine does have this whole PR: https://github.com/moby/moby/pull/36396/files https://github.com/balena-os/balena-engine/blob/master/cmd/dockerd/config_unix.go#L28 https://github.com/balena-os/balena-engine/blob/master/daemon/config/config.go#L117 I don't have a /etc/docker/daemon.json on my bob though https://straz.to/2021-09-08-docker-address-pools/ @majorz What is handling that instead...

I added a test and some error handling but not quite ready to merge this as my tests aren't working when I run individual tests. The migrate_test.go tests pass when...

That . worked! :) thanks @lmbarros

Adding this here as reference for all the changes to make this happen: https://github.com/balena-os/balena-engine/pull/168/files And the improvement: https://jel.ly.fish/product-improvement-migrate-device-storage-driver-from-aufs-to-overlayfs-22cf335f-b1f7-44f8-853d-064681c69fd8

Update on this @lmbarros : Was hoping to get a rpi3 to test on, Ross is sending one. Also trying to set up QEMU to test this on for quicker...

@lmbarros I made the changes to test and cleanup so it removes all the overlay2 folders/containers on rollback, instead of just removing the single layer with the missing config.v2.json. Should...

We (@cywang117 ) think this should be addressed with a change to the db to accept longer text(ipv6 and mac addresses) so will open an issue with the api team....