Tomislav Jovanovic comments

Results 6 comments of


                                            Tomislav Jovanovic

Rewriting core game loop to be tick based

(note: my current understanding of HS gameloop/ticks is still blurry, so excuse any mistakes) this looks like major surgery on the engine, being able to pause any "script", only to...

Consider to redact user picture when PR changes

Hey @allan-silvawhat, thanks for reporting. Can you please share the url of that PR, so that I can investigate?

Consider to redact user picture when PR changes

Thanks, I've already found and fixed the issue, and have been testing it locally, just forgot to update here. The fix should be in the next week update on AMO.

GitHub PR: username in document.title is not redacted

Ah, that part of the tab title is rarely visible, good catch. Might be a bit tricky to fix because of the lack of structure (in combination with GitHub's use...

Inline Comments not Redacted

Hey @ax3l, thanks for reporting. Do you have an example PR url perhaps, so that I can investigate?

Add the ability to load and test web extensions.

I've just confirmed this still runs and passes the sample tests with a Firefox build from latest checkout, and also with python wpt run --channel=nightly --install-browser firefox web-extensions --no-headless