Mingliang Zhu
Mingliang Zhu
Different from #52210, the cache mapping is moved to `BlockInfoManager`, and write/remove synchronously with `blockInfoWrappers`.
@holdenk Thank you. Could you please tell me how to design this unit test? Existing tests `BlockManagerSuite` already ensure that blockId is used and cleaned up normally.
@holdenk Can you help take a look again? Thanks.
OffloadOthers(), OffloadExchange(), and OffloadJoin() do not traverse the plan internally, so I also think DummyLeafExec is not necessary.
> Can we keep the hiding children logic in testing only? We should make sure the single node rules doesn't touch the children nodes to keep the logic atomic. If...
cc @Yuhta
> Can you upload the `tmp/t1` here? [t1.tar.gz](https://github.com/user-attachments/files/17405047/t1.tar.gz) and use `spark.range(1000)` easier to reproduce. @Yuhta
@Yuhta What is your system info? I can reproduce it on ubuntu22.04. I tried it on mac before and couldn't reproduce it. ``` root@from:/velox# _build/release/velox/dwio/parquet/tests/reader/velox_dwio_parquet_table_scan_test --velox_exception_user_stacktrace_enabled=true --gtest_filter="ParquetTableScanTest.aggregatePushdown" Note: Google Test...
> It could be a compiler difference. Are you using gcc? Can you try clang and see if it still repros? Yes, clang cannot reproduce, but gcc can.