Mingliang Zhu comments

Results 39 comments of


                                            Mingliang Zhu

[GLUTEN-7685][VL][RAS] Optimize rough model

> @zml1206 Can you add one line in PR description to demonstrate the way to enable this cost model? Thanks. Added.

[VL] Diff on parquet agg

cc @rui-mo @FelixYBW @zhztheplayer Have you encountered similar problems?

[VL] Diff on parquet agg

> No. Looks like a new Velox bug. Would you debug it? Sorry, there are problems with local mac compilation of new version, I can’t debug it for the time...

[VL] Diff on parquet agg

One more thing, I cannot reproduce on mac.

[VL] Diff on parquet agg

Through testing, found that https://github.com/facebookincubator/velox/pull/11010 caused, it worked after reverted it.

[VL] Diff on parquet agg

> Thank you for update. Did you submit an issue to Velox? https://github.com/facebookincubator/velox/issues/11257

[VL] Diff on parquet agg

Resolved by https://github.com/facebookincubator/velox/pull/12176

add date_trunc spark function

> @zml1206 Would you like to rebase this PR? Thanks. Rebased, CI failures seems unrelated. @rui-mo

add date_trunc spark function

@rui-mo all comments resolved, can you help take a look again? thanks.

> Can you run the fuzzer test for 2 minutes to make sure it works? You could use `--only` to specify this function. > > Command example: https://github.com/facebookincubator/velox/blob/main/.github/workflows/scheduled.yml#L587-L596