Zacharias Luiten

Results 19 comments of Zacharias Luiten

Thanks @logaretm! Even though splitting up in to smaller components is a better approach and a good practice, it doesn't feel right to be forced to do so. When I...

@logaretm nice! Small detail: you probably want to show that `firstName` and `lastName` can be managed by `form2` (your example uses `form1`). > const [firstName, lastName] = form2.useFieldModel(['firstName', 'lastName']);

Would dropping support for older versions be a BC break? Composer will just prevent the consumer from upgrading when using non supported versions of `firebase/php-jwt` (assuming composer is the supported...

> Thanks @netiul for raising the issue. Your detailed analysis is awesome! Thanks for being positive :) > I don't think the current version would run on PHP 8 since...

@shochdoerfer I definitely would like to help with that move, but I'm caught up in work for a couple more weeks. So if anyone else wants to pick up the...

@shochdoerfer It's actually not very hard to support both. [This is](https://github.com/netiul/disco/blob/php8-rewrite/src/bitExpert/Disco/Proxy/Configuration/MethodGenerator/ParameterAwareMethodGenerator.php#L58:L80) basically all that's needed, but it might be a bit confusing in userland to have both ways availabe...

@shochdoerfer I've have updated the top post with a summary of the main changes and some points up for discussing.

Yes! Sorry for the late reply :) Thank for the feedback @heiglandreas. It makes totally sense to use the functions signature to declare defaults and what parameter is required. Funny...

I will process the feedback shortly. I am currently stuck in work.

Ah, yes, we're still on the (latest) 3.4... I guess back porting the fix would solve the issue here. Not sure if that can be done while keeping BC